Add Quarkus plugin #291
Add Quarkus plugin #291
Conversation
Signed-off-by: svor <[email protected]>
svor
requested review from
amisevsk,
ibuziuk,
l0rd,
nickboldt,
rhopp,
skabashnyuk and
vparfonov
as code owners
| icon: https://www.eclipse.org/che/images/logo-eclipseche.svg | ||
| repository: https://github.com/redhat-developer/vscode-quarkus | ||
| category: Language | ||
| firstPublicationDate: "2019-11-25" |
There was a problem hiding this comment.
This date is now wrong :)
| containers: | ||
| - image: "docker.io/eclipse/che-remote-plugin-runner-java8:next" | ||
| name: vscode-quarkus | ||
| memoryLimit: "1500Mi" |
There was a problem hiding this comment.
Per discussion in eclipse-che/che-devfile-registry#144 (comment) is 1.5G enough memory?
There was a problem hiding this comment.
i didn't try big projects, but for https://github.com/quarkusio/quarkus-quickstarts.git samples 1.5G is enough
| - mountPath: "/home/theia/.m2" | ||
| name: m2 | ||
| extensions: | ||
| - https://github.com/microsoft/vscode-java-debug/releases/download/0.23.0/vscode-java-debug-0.23.0.vsix |
There was a problem hiding this comment.
Should we also update https://github.com/eclipse/che-plugin-registry/blob/master/v3/plugins/redhat/java11/0.50.0/meta.yaml#L22 and https://github.com/eclipse/che-plugin-registry/blob/master/v3/plugins/redhat/java8/0.50.0/meta.yaml#L22 and https://github.com/eclipse/che-plugin-registry/blob/master/v3/plugins/redhat/java/0.50.0/meta.yaml#L22 to use this newer version of the debug plugin?
There was a problem hiding this comment.
I've created an issue for that. eclipse-che/che#15560
There was a problem hiding this comment.
LGTM, tested using devfile in eclipse-che/che-devfile-registry#144
Signed-off-by: svor <[email protected]>
Signed-off-by: svor <[email protected]>
Signed-off-by: svor [email protected]
What does this PR do?
Registers Quarkus plugin. The plugin will be run in a container with
docker.io/eclipse/che-remote-plugin-runner-java8:nextimage and include next VS Code extensions: